Name Collision on AuthenticationValues

Options
There are two copies of the AuthenticationValues class, one in LoadBalancingPeer and one in ChatPeer.

The LoadBalancingPeer one is not under a namespace, so when attempting to use the class with the Chat API, it uses the wrong one.

This is a minor issue, but the classes look almost identical and should either be merged or the LoadBalancingPeer one should be under a namespace.

EDIT:
CustomAuthenticationType appears to have the same issue.

Comments

  • Tobias
    Options
    The LoadBalancing API (short: LB) and PUN are not built to be combined in one project. Due to how developers were used to work in Unity, we don't have the namespaces everywhere and things collide because the task is the same and some things are shared while other code diverged over time (PUN got done after the LoadBalancing API but is sadly not based on it entirely).

    In the end, we can't currently support LB in PUN. We just don't have the time currently.

    Despite that, some advice:
    Chat was modified to run with PUN. If you copy over LB, avoid the duplicate classes (keep the ones from PUN) and try to adjust the LB code to run with the slightly different classes.

    I'm sorry I have no better news.
  • vadim
    Options
    Probably the original question is not about LB.
    The issue should appear if you import entire Chat namespace.
    So this is not big problem and can be easily avoided.