BoltConnection.UserData disposed automatically on Disconnect - would like this removed
Options
DirtyHippy
✭✭
in Photon Bolt
Internally Bolt calls Dispose on connection UserData that implements IDisposable on Disconnect (after the disconnected callbacks). This is unexpected IMHO, and actually something I never bothered to track down until now. This is user data and owned by me. I expect to dispose it when I feel it is necessary.
I propose removing the internal call to Dispose as this object is owned by me. Of course the userdata would still be nulled out.
There is a workaround right now: simply nulling out the user data in the disconnected callback so Bolt has nothing to dispose.
The only problem with this proposed change is that it is potentially breaking behaviour for anyone relying on this internal dispose, although the fix would be fairly trivial.
Thoughts?
I propose removing the internal call to Dispose as this object is owned by me. Of course the userdata would still be nulled out.
There is a workaround right now: simply nulling out the user data in the disconnected callback so Bolt has nothing to dispose.
The only problem with this proposed change is that it is potentially breaking behaviour for anyone relying on this internal dispose, although the fix would be fairly trivial.
Thoughts?
0